[linux-mm-cc] [UTIL PATCH] add new proc entry to fix algorithm

IKEDA Munehiro m-ikeda at ds.jp.nec.com
Wed May 9 07:57:47 EDT 2007


Nitin Gupta wrote:
> Hi,
> 
> Changes look good. Trivial comments below.
> 
> 
>>+               .data           = &ccache_fixed_algo,
> 
> 
> s/ccache_fixed_algo/ccache_selected_algo - looks clearer.

I agree.


>>+int sysctl_cc_algorithm(ctl_table *table, int write,
>>+       struct file *file, void __user *buffer, size_t *length, loff_t *ppos)
>>+{
>>+       return proc_dointvec_minmax(table, write, file, buffer, length, ppos);
>>+}
>>+
> 
> 
> It will be good to show available compression algos (idx-name pair)
> when this proc entry is read.

OK. I'll do it and post later.

Thank you for good sugestions.


Best regards,
IKEDA, Munehiro



More information about the linux-mm-cc mailing list