[linux-mm-cc] [UTIL PATCH] add new proc entry to fix algorithm

Nitin Gupta nitingupta.mail at gmail.com
Wed May 9 02:25:05 EDT 2007


Hi,

Changes look good. Trivial comments below.

> +               .data           = &ccache_fixed_algo,

s/ccache_fixed_algo/ccache_selected_algo - looks clearer.


> +int sysctl_cc_algorithm(ctl_table *table, int write,
> +       struct file *file, void __user *buffer, size_t *length, loff_t *ppos)
> +{
> +       return proc_dointvec_minmax(table, write, file, buffer, length, ppos);
> +}
> +

It will be good to show available compression algos (idx-name pair)
when this proc entry is read.

Thanks for changes.

Cheers,
Nitin


More information about the linux-mm-cc mailing list