[PATCH 0/3] PM patch review (redux)

Jordan Crouse jordan.crouse at amd.com
Fri Mar 2 16:36:03 EST 2007


Following is a review of the patches I've sent over the last few days.
They are the same, except for the first, which has changed dramatically -
I added a PCI driver to the Geode southbridge code so we can support
suspend/resume.  Its also slightly less fraudulent to read the base
addresses from the PCI headers then from the MSRs.

The point of all that extra work was to support suspend/resume for the
I2C driver.  I'm more happy then I've ever been with the way the I2C driver
handles the different Geode flavors, but thats like saying I'm more happy
to get stabbed in the face then shot in the head.

Comments welcome.

Jordan





More information about the Devel mailing list