#9222 HIGH 8.2.1: WEP broken in staging-8

[Zarro Boogs per Child]

#9222: WEP broken in staging-8
--------------------------------+-------------------------------------------
           Reporter:  ivazquez  |       Owner:  dsaxena      
               Type:  defect    |      Status:  new          
           Priority:  high      |   Milestone:  8.2.1        
          Component:  kernel    |     Version:  not specified
         Resolution:            |    Keywords:               
        Next_action:  diagnose  |    Verified:  0            
Deployment_affected:            |   Blockedby:               
           Blocking:            |  
--------------------------------+-------------------------------------------

Comment(by dsd):

 untested theory, but I think I see the bug in the code by inspection.
 Caused by b0a7455f0b.

 In lbs_set_encodeext there is a code block for installing WEP/WPA keys,
 but the code flow is different for each one, and I think I see an obvious
 bug in the WEP path:

 {{{
         } else if (alg == IW_ENCODE_ALG_WEP) {
              //keys installed here
              lbs_postpone_association_work(priv);
         } else (WPA stuff) {
              //keys installed here
              goto done;
         }

 cancel:
         lbs_cancel_association_work(priv);
 done:
         mutex_unlock(&priv->lock);

         lbs_deb_leave_args(LBS_DEB_WEXT, "ret %d", ret);
         return ret;

 }}}

 So, for the WEP case, we fall through to the "cancel" label.  I don't
 think that is what we want?

-- 
Ticket URL: <http://dev.laptop.org/ticket/9222#comment:5>
One Laptop Per Child <http://laptop.org/>
OLPC bug tracking system