#6274 NORM 8.2.0 (: Analyze-activity mis-prints MAC address

[Zarro Boogs per Child]

#6274: Analyze-activity mis-prints MAC address
----------------------------------------+-----------------------------------
           Reporter:  yfarjoun          |       Owner:  edsiper                
               Type:  defect            |      Status:  new                    
           Priority:  normal            |   Milestone:  8.2.0 (was Update.2)   
          Component:  analyze-activity  |     Version:  Build 653              
         Resolution:                    |    Keywords:  MAC address hex review?
        Next_action:  never set         |    Verified:  0                      
Deployment_affected:                    |   Blockedby:                         
           Blocking:                    |  
----------------------------------------+-----------------------------------
Changes (by yfarjoun):

  * next_action:  => never set


Comment:

 Replying to [ticket:6274 yfarjoun]:

 I noticed that this wasn't included in the release....should I do anything
 to move it along? I know it's not a big issue, but it would be nice to
 have it fixed...


 > When looking at the MAC address of a interface where some of the HEX
 entries are less than 16, the first 0 is ommited. Thus 0x0c comes out as
 :c:. This is not the standard way (I think).
 >
 > The problem is in netdevice.py line 77 (from the head)
 >
 > 77                 hdigit = hex(ord(char))[2:]
 >
 > should instead be
 >
 > 77                 hdigit = '%02x'%ord(char)
 >
 > or similar.
 >
 > I can create a patch, but I wanted to see what people think of this
 first. (Thus I've assigned this to me..)
 >

-- 
Ticket URL: <http://dev.laptop.org/ticket/6274#comment:5>
One Laptop Per Child <http://laptop.org/>
OLPC bug tracking system