[sugar] [PATCH] Refactor invites for 1-1 Chat (#6298)

[Morgan Collett]

On Wed, Jun 4, 2008 at 17:25, Guillaume Desmottes
<guillaume.desmottes at collabora.co.uk> wrote:
> Le mercredi 04 juin 2008 à 17:08 +0200, Morgan Collett a écrit :
>> The main code to review is at:
>> http://dev.laptop.org/git?p=users/morgan/sugar;a=shortlog;h=6298 (3
>> most recent patches).
>
> As bundle_id is passed to both constructor, you could move it to
> BaseInvite.__init__
>
>
> Didn't read code carefully but InviteButton and InvitePalette still
> contain lot of:
>
> if shared:
>  ...
> else:
>  # private
>
>
> Maybe it would be worth to abstract these 2 classes too if possible?

Done, in the patch
http://dev.laptop.org/git?p=users/morgan/sugar;a=commitdiff;h=0383581b2789fa7a8d0f8eb99da6068eb67b5500

Sugar Team, please can I have further review:

The main code to review is at:
http://dev.laptop.org/git?p=users/morgan/sugar;a=shortlog;h=6298 (4
most recent patches).

http://dev.laptop.org/git?p=users/morgan/sugar-toolkit;a=shortlog;h=6298
- Guillaume's change, r+ from me
- Can I push this to sugar-toolkit?

Related changes are at:
http://dev.laptop.org/git?p=users/morgan/presence-service;a=shortlog;h=6298
- Guillaume's change, r+ from me
- Waiting on the above sugar-toolkit patch approval
http://dev.laptop.org/git?p=users/morgan/chat-activity;a=shortlog;h=6298
- r+ from me for all Guillaume's changes

Regards
Morgan