[sugar] [PATCH] Refactor invites for 1-1 Chat (#6298)

Guillaume Desmottes guillaume.desmottes at collabora.co.uk
Wed Jun 4 11:25:07 EDT 2008


Le mercredi 04 juin 2008 à 17:08 +0200, Morgan Collett a écrit :
> The main code to review is at:
> http://dev.laptop.org/git?p=users/morgan/sugar;a=shortlog;h=6298 (3
> most recent patches).

As bundle_id is passed to both constructor, you could move it to
BaseInvite.__init__


Didn't read code carefully but InviteButton and InvitePalette still
contain lot of:

if shared:
  ...
else:
  # private


Maybe it would be worth to abstract these 2 classes too if possible?



	G.



More information about the Sugar mailing list