[Server-devel] [PATCH] Introducing ds_backup.sh - a lightweight wrapper.

[Martin Langhoff]

On Mon, Jun 16, 2008 at 5:08 PM, Michael Stone <michael at laptop.org> wrote:
> On Mon, Jun 16, 2008 at 01:46:32PM -0400, martin.langhoff at gmail.com wrote:
>> From: Martin Langhoff <martin at laptop.org>
>> +# make the lock dir if needed
>> +if [ ! -d ~/.sugar/default/lock ]
>> +then
>> +    mkdir ~/.sugar/default/lock
>> +fi
>
> Why not use /var/lock like everybody else? We can add appropriate users
> to the lock group if needed. (Or however Fedora does these things.) Are
> we better off making ~/.sugar/default contain our complete parallel
> FHS?

I suggested /var/lock too, but I'm following Tomeu's hints here
http://lists.laptop.org/pipermail/devel/2008-May/014440.html

>> +# Clean up the lock - if we can ;-)
>> +rm $LOCKFILE 2>/dev/null
>
> Why bother to add more writes to JFFS2? Presumably we'll be reusing the
> same file in a few minutes.

good point.

Had a chance to peruse  Tomeu's patch?




m
-- 
 martin.langhoff at gmail.com
 martin at laptop.org -- School Server Architect
 - ask interesting questions
 - don't get distracted with shiny stuff - working code first
 - http://wiki.laptop.org/go/User:Martinlanghoff