[Server-devel] [PATCH] Introducing ds_backup.sh - a lightweight wrapper.

Michael Stone michael at laptop.org
Mon Jun 16 17:08:03 EDT 2008


On Mon, Jun 16, 2008 at 01:46:32PM -0400, martin.langhoff at gmail.com wrote:
> From: Martin Langhoff <martin at laptop.org>
> +# make the lock dir if needed
> +if [ ! -d ~/.sugar/default/lock ]
> +then
> +    mkdir ~/.sugar/default/lock
> +fi

Why not use /var/lock like everybody else? We can add appropriate users
to the lock group if needed. (Or however Fedora does these things.) Are
we better off making ~/.sugar/default contain our complete parallel
FHS?

> +# Clean up the lock - if we can ;-)
> +rm $LOCKFILE 2>/dev/null

Why bother to add more writes to JFFS2? Presumably we'll be reusing the
same file in a few minutes.

Michael


More information about the Server-devel mailing list