Browse-129 PDF fork for 11.3.0

[Simon Schampijer]

On 10/04/2011 02:33 PM, Daniel Drake wrote:
> Hi,
>
> As agreed yesterday I had a quick look at the PDF plugin reader for
> 11.3.0 and the addition of ARM support.
>
> Thanks to the earlier packaging by Gonzalo this was actually very
> easy. Pushed to
> http://git.sugarlabs.org/~godiard/browse/inline-pdf-11-2
>
> packaged into:
> http://dev.laptop.org/~dsd/20111004/Browse-129.1.xo
>
> Tested on both XO-1.5 and and XO-1.75, seems to be working as well as before.
>
> I think our discussion yesterday was leaning towards shipping this if
> it could be restored without too much hassle - which has now been
> done. Any objections?
>
> It would be great to get a little more testing before I put it in the build.
>
> And lets not forget to fix this properly next cycle...
>
> Thanks,
> Daniel

Thanks Daniel for working on this!

A few notes from my testing:

- tested three different pdfs as showing as expected [1][2][3]

- I can either click on the link directly or open it in a new tab 
(palette option)

- I can use the 'save to Journal' option and reveal them using the Read 
activity ([1] does show a strange title though 'Document:", the log do 
not show why), enhancement: would be nice to add here the download link 
in the description field like we do for other downloads

- I can share a link using the session bookmarks (machine A), however on 
B when clicking on the link we try to download the pdf instead of 
showing it in Browse

- there is a funny drawing error when you switch to another view while 
the pdf is loading (see screenshot where the status alert is drawn in 
the neighborhood view) (os8 on a 1.5)

- with a subtoolbar expanded the view is heavily-toolbar oriented, but 
still looks ok (screenshot attached for reference)

Regards,
    Simon

[1] http://dev.laptop.org/~erikos/photo_163970-da-01-en-TSL250R.pdf
[2] http://dev.laptop.org/~erikos/reason.pdf
[3] http://dev.laptop.org/~erikos/test.pdf

-------------- next part --------------
A non-text attachment was scrubbed...
Name: glitch-loading.png
Type: image/png
Size: 20734 bytes
Desc: not available
URL: <http://lists.laptop.org/pipermail/devel/attachments/20111005/8a24e204/attachment.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tabs-pdf-subtoolbar.png
Type: image/png
Size: 89265 bytes
Desc: not available
URL: <http://lists.laptop.org/pipermail/devel/attachments/20111005/8a24e204/attachment-0001.png>