olpc-utils: hwinfo and reading mfg-data
Martin Langhoff
martin.langhoff at gmail.com
Mon Aug 15 17:44:02 EDT 2011
On Mon, Aug 15, 2011 at 4:44 PM, Paul Fox <pgf at laptop.org> wrote:
> this information is easy to provide by using an exit code to mean
> "missing". probably should have done that in the first place.
> untested patch below.
If it tests alright, please go ahead and commit it :-)
> > You may also note that the shell functions don't add a
> > newline.
>
> i think this is unnecessary, though i guess it's harmless. the shell
> will remove the added newline during expansion in any case, so its
> presence or absence doesn't really matter. likewise, per your comment,
> remove null characters is unnecessary.
Maybe I've been pointlessly tidy -- had to happen once!
> i seem to have used spaces, and you used tabs. either is fine with me,
> but we should make it uniform with one more commit.
Apologies for the mix. I don't care one way or the other.
m
--
martin.langhoff at gmail.com
martin at laptop.org -- Software Architect - OLPC
- ask interesting questions
- don't get distracted with shiny stuff - working code first
- http://wiki.laptop.org/go/User:Martinlanghoff
More information about the Devel
mailing list