Commit 2671e48d broke camera on XO-1

[Jonathan Corbet]

On Sun, 14 Mar 2010 00:00:04 +0100
Sascha Silbe <sascha-ml-ui-sugar-olpc-devel at silbe.org> wrote:

> One of your somewhat recent commits, 2671e48d [1], broke the camera on 
> XO-1.

I saw the bug entry, yes.

> The TWSI port is Vdd=2.5..3.3V only, so not fully I2C compliant => SMBus 
> is the best fit.

Yes, but...communications with the ov7670 have always been dicey, on
the XO too.  Trying to speak SMBUS to it was a fundamental mistake.

> So I guess the best "fix" would be to make your changes dependant on the 
> machine, using the olpc_board_at_least() function.

If need be, that's how it will go, but I'd hate to solve the problem
that way.  The proper solution is likely to be in the Cafe driver;
that's where I'll look first. 

Thanks,

jon