[PATCH] viafb: Do not probe for LVDS/TMDS on OLPC XO-1.5

Chris Ball cjb at laptop.org
Mon Jun 8 10:37:47 EDT 2009

Hi Dan,

   > I don't think that's upstream suitable. It will cripple any
   > non-XO system that boots a kernel with that option
   > included. Remember that distributors like Fedora ship their
   > generic kernels to the whole world with CONFIG_OLPC enabled.

Thanks, you're right.

   > At the very least there should be a runtime "am i an XO" check
   > inside the ifdef..although ideally we could find (with Harald) a
   > less ugly way of doing this.

"if (machine_is_olpc())" is the right way to do this check, but it's
returning false on the 1.5 board at the moment.  I'll commit a patch
that uses that once it's hooked up, and we can use that patch to
start a discussion upstream about the preferred way to do this.

- Chris.
Chris Ball   <cjb at laptop.org>

More information about the Devel mailing list