[PATCH] viafb: Do not probe for LVDS/TMDS on OLPC XO-1.5

Daniel Drake dsd at laptop.org
Mon Jun 8 06:27:19 EDT 2009

On Sun, 2009-06-07 at 19:00 -0400, Chris Ball wrote:
> Hi Harald,
> Here's a tested patch to remove the 25-second delay we were seeing on
> boot with viafb.  If you think it makes more sense to add this as a
> "viafb_noprobe_{lvds,tmds}" pair of params, I'd be happy to do that.
> Please review and send upstream.

I don't think that's upstream suitable. It will cripple any non-XO
system that boots a kernel with that option included. Remember that
distributors like Fedora ship their generic kernels to the whole world
with CONFIG_OLPC enabled.

At the very least there should be a runtime "am i an XO" check inside
the ifdef..although ideally we could find (with Harald) a less ugly way
of doing this.


More information about the Devel mailing list