[PATCH 5/5] gxfb: Adjust the powerdown behavior when a DCON is attached

Jeff Keller jeff.keller at gmail.com
Thu Apr 26 00:05:45 EDT 2007


I'm not familiar with the code (I was just idly skimming your diffs),
but in the snippet below, the new comment looks like it's at odds with
the new conditional.  Am I misreading it?
--Jeff

On 4/25/07, Jordan Crouse <jordan.crouse at amd.com> wrote:
>
> ...
> diff --git a/drivers/video/geode/video_gx.c
> b/drivers/video/geode/video_gx.c
> index b0e4303..13fce28 100644
> --- a/drivers/video/geode/video_gx.c
> +++ b/drivers/video/geode/video_gx.c
> ...
> @@ -370,9 +371,13 @@ int gxfb_powerdown(struct fb_info *info) {
>         gx_pm_regs[VC_DCFG] = readl(par->vid_regs + GX_DCFG);
>         writel(gx_pm_regs[VC_DCFG] & ~0x0F, par->vid_regs + GX_DCFG);
>
> -       /* Turn off the flat panel */
> -       gx_pm_regs[VC_FP_PM] = readl(par->vid_regs + GX_FP_PM);
> -       writel(gx_pm_regs[VC_FP_PM] & ~GX_FP_PM_P, par->vid_regs +
> GX_FP_PM);
> +       /* Turn off the flat panel unless we are attached to a DCON */
> +
> +       if (!olpc_has_dcon()) {
> +               gx_pm_regs[VC_FP_PM] = readl(par->vid_regs + GX_FP_PM);
> +               writel(gx_pm_regs[VC_FP_PM] & ~GX_FP_PM_P,
> +                       par->vid_regs + GX_FP_PM);
> +       }
>
>         /* Unlock the DC - this will remain unlocked until power up */
>         writel(0x4758, par->dc_regs + DC_UNLOCK);
> ...
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.laptop.org/pipermail/devel/attachments/20070426/8d35cb0b/attachment.html>


More information about the Devel mailing list