I'm not familiar with the code (I was just idly skimming your diffs),<br>but in the snippet below, the new comment looks like it's at odds with<br>the new conditional.  Am I misreading it?<br>--Jeff<br><br><div><span class="gmail_quote">
On 4/25/07, <b class="gmail_sendername">Jordan Crouse</b> <<a href="mailto:jordan.crouse@amd.com">jordan.crouse@amd.com</a>> wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
...<br>diff --git a/drivers/video/geode/video_gx.c b/drivers/video/geode/video_gx.c<br>index b0e4303..13fce28 100644<br>--- a/drivers/video/geode/video_gx.c<br>+++ b/drivers/video/geode/video_gx.c<br>...<br>@@ -370,9 +371,13 @@ int gxfb_powerdown(struct fb_info *info) {
<br>        gx_pm_regs[VC_DCFG] = readl(par->vid_regs + GX_DCFG);<br>        writel(gx_pm_regs[VC_DCFG] & ~0x0F, par->vid_regs + GX_DCFG);<br><br>-       /* Turn off the flat panel */<br>-       gx_pm_regs[VC_FP_PM] = readl(par->vid_regs + GX_FP_PM);
<br>-       writel(gx_pm_regs[VC_FP_PM] & ~GX_FP_PM_P, par->vid_regs + GX_FP_PM);<br>+       /* Turn off the flat panel unless we are attached to a DCON */<br>+<br>+       if (!olpc_has_dcon()) {<br>+               gx_pm_regs[VC_FP_PM] = readl(par->vid_regs + GX_FP_PM);
<br>+               writel(gx_pm_regs[VC_FP_PM] & ~GX_FP_PM_P,<br>+                       par->vid_regs + GX_FP_PM);<br>+       }<br><br>        /* Unlock the DC - this will remain unlocked until power up */<br>        writel(0x4758, par->dc_regs + DC_UNLOCK);
<br>...</blockquote></div><br>