[MTD] NAND: Café ECC -- remove spurious BUG ON() in err pos()

David Woodhouse dwmw2 at infradead.org
Tue Nov 7 22:38:27 EST 2006


Commit:     2c8cfdcbeb1ab0ec7bbd5af1be311b55281154c4
Parent:     470b0a90d6a21cb72b671215f12ec7ec8a0db2c0
commit 2c8cfdcbeb1ab0ec7bbd5af1be311b55281154c4
Author:     David Woodhouse <dwmw2 at infradead.org>
AuthorDate: Fri Oct 27 09:53:08 2006 +0300
Commit:     David Woodhouse <dwmw2 at infradead.org>
CommitDate: Fri Oct 27 09:53:08 2006 +0300

    [MTD] NAND: Café ECC -- remove spurious BUG_ON() in err_pos()
    
    Being a value which isn't in the table is a case we explicitly check for
    in the caller. Don't BUG_ON() because it does actually happen in
    practice.
    
    Signed-off-by: David Woodhouse <dwmw2 at infradead.org>
---
 drivers/mtd/nand/cafe_ecc.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/mtd/nand/cafe_ecc.c b/drivers/mtd/nand/cafe_ecc.c
index c4bec37..4621460 100644
--- a/drivers/mtd/nand/cafe_ecc.c
+++ b/drivers/mtd/nand/cafe_ecc.c
@@ -1045,7 +1045,6 @@ static unsigned short err_pos_lut[4096] 
 static unsigned short err_pos(unsigned short din)
 {
 	BUG_ON(din > 4096);
-	BUG_ON(err_pos_lut[din] == 0xfff);
 	return err_pos_lut[din];
 }
 static int chk_no_err_only(unsigned short *chk_syndrome_list, unsigned short *err_info)


More information about the Commits-kernel mailing list