[Code-review] review: Gadget notify-activity-members branch

[Guillaume Desmottes]

Le vendredi 15 août 2008 à 20:17 +0100, Dafydd Harries a écrit :
> Looks nice. Just one thing to change:
> 
> >+        for node in properties_to_xml(buddy.properties):
> 
> This should be updated to the new API.

Humm that's weird. That was already fixed but didn't appear on monkey.


> >+        for view in self.activity_views:
> >+            for activity in view.results:
> >+                if buddy.jid in activity.members:
> >+                    view.handler.buddy_changed(buddy)
> 
> ...
> 
> >+        for view in self.activity_views:
> >+            for activity in view.results:
> >+                if buddy.jid in activity.members:
> >+                    view.handler.buddy_current_activity_changed(buddy)
> 
> These look a bit scary scaling-wise. But the simulator I've been working on
> should tell us how expensive they are.

I added a FIXME so we won't forgot to check that when we'll do
performance tests.

notify-activity-members merged to master.


Thanks for the review,


	G.