[Code-review] review: Gadget notify-activity-members branch

Dafydd Harries dafydd.harries at collabora.co.uk
Fri Aug 15 15:17:40 EDT 2008


Looks nice. Just one thing to change:

>+        for node in properties_to_xml(buddy.properties):

This should be updated to the new API.

>+        for view in self.activity_views:
>+            for activity in view.results:
>+                if buddy.jid in activity.members:
>+                    view.handler.buddy_changed(buddy)

...

>+        for view in self.activity_views:
>+            for activity in view.results:
>+                if buddy.jid in activity.members:
>+                    view.handler.buddy_current_activity_changed(buddy)

These look a bit scary scaling-wise. But the simulator I've been working on
should tell us how expensive they are.

-- 
Dafydd


More information about the Code-review mailing list