[Code-review] review: Gadget current-activity branch
guillaume.desmottes at collabora.co.uk
Thu Aug 14 13:01:25 EDT 2008
Le jeudi 14 août 2008 à 15:11 +0100, Dafydd Harries a écrit :
> Ar 12/08/2008 am 12:06, ysgrifennodd Guillaume Desmottes:
> > Le lundi 11 août 2008 à 17:13 +0100, Dafydd Harries a écrit :
> > > >+ # (room, activity id)
> > > >+ self.current_activity = ('', '')
> > >
> > > Why not make this an activity object? (Or None for no current activity.)
> > Then that implies that if Gadget is notified about a current-act change
> > involving an activity which is not in Gadget's model, we'll have to set
> > buddy's current-act to None.
> > Is that something we want? IIRC, we agreed that Gadget should always fw
> > notifications and that's client's job to ignore this notification if
> > that's an unknown activity.
> Well, we could still use an Activity object: it doesn't have to be in the
Right. I did that but I'm not sure if we should reuse Activity object
from the model or not. See my FIXME.
More information about the Code-review