[Code-review] review: Gadget current-activity branch

Dafydd Harries dafydd.harries at collabora.co.uk
Mon Aug 11 12:49:51 EDT 2008


>+    def remove_buddy(self, buddy):
>+        self.results.remove(buddy)
>+        self.handler.buddy_removed(buddy)

Perhaps we can add a FIXME here; something like:

  # FIXME: add more results here if len(self.results) <= self.size

Otherwise, +1.

-- 
Dafydd


More information about the Code-review mailing list