#11816 NORM 12.1.0: First Sugar boot - simple welcome screen

Zarro Boogs per Child bugtracker at laptop.org
Mon Jun 18 15:50:00 EDT 2012


#11816: First Sugar boot - simple welcome screen
---------------------------------------+------------------------------------
           Reporter:  martin.langhoff  |       Owner:  godiard      
               Type:  enhancement      |      Status:  new          
           Priority:  normal           |   Milestone:  12.1.0       
          Component:  sugar            |     Version:  not specified
         Resolution:                   |    Keywords:               
        Next_action:  diagnose         |    Verified:  0            
Deployment_affected:                   |   Blockedby:               
           Blocking:                   |  
---------------------------------------+------------------------------------

Comment(by godiard):

 Replying to [comment:40 dsd]:
 > I pushed this, but 2 comments:
 >
 > Do we need checks around gobject.source_remove to make sure we aren't
 removing a non-existant timeout or one that has already been removed?
 >

 No. If does not exist, just return False. [1]

 >
 http://git.sugarlabs.org/welcomeactivity/mainline/commit/92a841e0cd4dc3d0d7969a1446a0d8c012b80989
 is ugly and (to me) suggests that sugar is launching this from the wrong
 place.

 Well, is a little ugly, but if you look at activity.py code [2], will see
 is setting the property too. We can use the style constants, it's true.
 If you look at the patch to sugar-session from erikos, the welcome
 activity is started after set_fonts(), and I have tried moving the code
 after the line before the home window is created but is the same.

 [1] http://www.pygtk.org/pygtk2reference/gobject-functions.html#function-
 gobject--source-remove

 [2] http://git.sugarlabs.org/sugar-
 toolkit/mainline/blobs/master/src/sugar/activity/activity.py#line266

-- 
Ticket URL: <http://dev.laptop.org/ticket/11816#comment:41>
One Laptop Per Child <http://laptop.org/>
OLPC bug tracking system


More information about the Bugs mailing list