#12206 NORM 13.1.0: XO-1.75 rotation rendering error

[Zarro Boogs per Child]

#12206: XO-1.75 rotation rendering error
---------------------------------------+------------------------------------
           Reporter:  greenfeld        |       Owner:  jnettlet                         
               Type:  defect           |      Status:  new                              
           Priority:  normal           |   Milestone:  13.1.0                           
          Component:  x window system  |     Version:  Development build as of this date
         Resolution:                   |    Keywords:                                   
        Next_action:  review           |    Verified:  0                                
Deployment_affected:                   |   Blockedby:                                   
           Blocking:                   |  
---------------------------------------+------------------------------------

Comment(by dsd):

 Jon suggested that this would have a negative impact on full-screen
 rotation. He's right; screen rotation results in composite blits with a
 rotation matrix. The rotation matrix only worked in this case as the
 matrix was somewhat ignored; full-screen rotation was special-cased.

 The updated patch (attached) fixes this by implementing accelerated
 rotated blits in general, which works for full-screen rotation (as before)
 and also for the smaller blits in the test case presented here.

 Assuming this looks better, what are your thoughts on this work's
 suitablity for 13.1.0? It is more complex than I had hoped, but it does
 fix a regression in Image Viewer (which apparently was not using
 accelerated rotation in 12.1.0). If it seems risky, we may have another
 option of detecting non-fullscreen rotated blits in PrepareComposite and
 rejecting them.

-- 
Ticket URL: <http://dev.laptop.org/ticket/12206#comment:4>
One Laptop Per Child <http://laptop.org/>
OLPC bug tracking system