#11353 HIGH 1.75-so: SD Card cannot detected in OS881

[Zarro Boogs per Child]

#11353: SD Card cannot detected in OS881
------------------------------------+---------------------------------------
           Reporter:  garysu        |       Owner:  cjb                                         
               Type:  defect        |      Status:  new                                         
           Priority:  high          |   Milestone:  1.75-software                               
          Component:  kernel        |     Version:  1.75/1.5/1.0 Software Build os883 aka 11.3.0
         Resolution:                |    Keywords:                                              
        Next_action:  add to build  |    Verified:  0                                           
Deployment_affected:                |   Blockedby:                                              
           Blocking:                |  
------------------------------------+---------------------------------------
Changes (by martin.langhoff):

  * next_action:  code => add to build


Comment:

 Works for me! Built kernel without CONFIG_MMC_UNSAFE_RESUME, and

  * S/R works correctly - eMMC does not get unmounted
  * Ext SD card insert detection works
  * With an ext SD card mounted, S/R succeeds. we see the "mmc0: card XXXX
 removed" messages on the way down, and then "mmc0: new SDIO card at
 address XXXX" (mmc1 msgs ignored, those are for libertas)

 Will push this to -wip.

 My only comment is one of style -- looking around, we could just map a
 "mmc_caps" property directly to the mmc host struct in pxa. This is
 already done with 'quirks' in sdhci-pxa.c for example. And sh_mobile_sdhi
 does exactly that with an equivalent struct member called tmio_caps.

 Seems more straightforward to users -- if you want MMC_CAP_FOO, you can
 just use it, rather than learn a new name, specific to a driver for the
 same thing.

-- 
Ticket URL: <http://dev.laptop.org/ticket/11353#comment:11>
One Laptop Per Child <http://laptop.org/>
OLPC bug tracking system