#10174 NORM Opportu: usbhid error unplugging a device

[Zarro Boogs per Child]

#10174: usbhid error unplugging a device
--------------------------------+-------------------------------------------
           Reporter:  dmoco     |       Owner:  cjb          
               Type:  defect    |      Status:  assigned     
           Priority:  normal    |   Milestone:  Opportunity  
          Component:  kernel    |     Version:  not specified
         Resolution:            |    Keywords:               
        Next_action:  diagnose  |    Verified:  0            
Deployment_affected:            |   Blockedby:               
           Blocking:            |  
--------------------------------+-------------------------------------------

Comment(by cjb):

 Ah, I worked out the location:

 {{{
 (gdb) list *hiddev_ioctl+0x25
 0x231f is in hiddev_ioctl (drivers/hid/usbhid/hiddev.c:401).
 396     static int hiddev_ioctl(struct inode *inode, struct file *file,
 unsigned int cmd, unsigned long arg)
 397     {

 401             struct usb_device *dev = hid_to_usb_dev(hid);
 }}}

 So, we'd expect that changing that to:

 {{{
 struct usb_device *dev;
 ...
 if (hid)
     dev = hid_to_usb_dev(hid);
 }}}

 would avoid the oops.  Derek, would you be able to test a new kernel if I
 build one?

-- 
Ticket URL: <http://dev.laptop.org/ticket/10174#comment:2>
One Laptop Per Child <http://laptop.org/>
OLPC bug tracking system