#8526 HIGH 8.2.0 (: display backlight dims for no good reason

[Zarro Boogs per Child]

#8526: display backlight dims for no good reason
-----------------------------------+----------------------------------------
   Reporter:  thomaswamm           |       Owner:  cjb                              
       Type:  defect               |      Status:  new                              
   Priority:  high                 |   Milestone:  8.2.0 (was Update.2)             
  Component:  power manager (OHM)  |     Version:  Development build as of this date
 Resolution:                       |    Keywords:  cjbfor8.2                        
Next_action:  diagnose             |    Verified:  0                                
  Blockedby:                       |    Blocking:  8006                             
-----------------------------------+----------------------------------------

Comment(by cjb):

 > value_user (0) isn't a default, so preserving.

 Guh, don't know what I was thinking here; these hacks that tried to guess
 whether a brightness selection was "user-set" or not should absolutely
 die.  (Thanks much for the reproduction method and logs.)

 I think the fix is:
  * Sugar should be setting backlight.value_user when the brightness keys
 are used
  * OHM should just reset to value_user when coming out of dim
  * All the garbage logic currently in reset_brightness should be deleted.

 It's annoying that this involves a Sugar change, albeit a simple string
 one.  If that's not palatable for 8.2, I guess we could reserve the
 preference Sugar is setting for it, and give ourselves a new "just set the
 brightness to this" function.  Does that all make sense?

-- 
Ticket URL: <http://dev.laptop.org/ticket/8526#comment:8>
One Laptop Per Child <http://laptop.org/>
OLPC bug tracking system