#7685 NORM 9.1.0: Alternate home layouts; fixed ring scaling; better modularization of layouts

[Zarro Boogs per Child]

#7685: Alternate home layouts; fixed ring scaling; better modularization of
layouts
-------------------------+--------------------------------------------------
   Reporter:  cscott     |       Owner:  marco        
       Type:  defect     |      Status:  new          
   Priority:  normal     |   Milestone:  9.1.0        
  Component:  sugar      |     Version:  not specified
 Resolution:             |    Keywords:  r?           
Next_action:  never set  |    Verified:  0            
  Blockedby:             |    Blocking:               
-------------------------+--------------------------------------------------

Comment(by mtd):

 I like the (sugar) patch (it's moved to
 http://dev.laptop.org/git?p=users/cscott/sugar;a=summary ), especially the
 modularization parts.  Comments on the patch are 1) there are a few times
 we do "y = m*x+b" instead of "y = m * x + b" that'd be nice to tidy up;
 and 2) I wish the "RingLayout" class's name could better express that it
 is suitable as a superclass to {Box,Triangle,Sunflower}Layout - perhaps
 RingLayout should be renamed BaseLayout and its _calculate_position()
 function should raise UnimplementedException, and then a new RingLayout
 defined, which implements that function as the current RingLayout does.

 If it were up to me it'd be r+ with those comments.  I don't know when it
 should land, though.

-- 
Ticket URL: <http://dev.laptop.org/ticket/7685#comment:7>
One Laptop Per Child <http://laptop.org/>
OLPC bug tracking system