#7248 NORM 8.2.0 (: Speaker device has inconsistent behavior

[Zarro Boogs per Child]

#7248: Speaker device has inconsistent behavior
-------------------------+--------------------------------------------------
   Reporter:  Eben       |       Owner:  mtd                              
       Type:  defect     |      Status:  new                              
   Priority:  normal     |   Milestone:  8.2.0 (was Update.2)             
  Component:  sugar      |     Version:  Development build as of this date
 Resolution:             |    Keywords:  8.2.0:+ r?                       
Next_action:  never set  |    Verified:  0                                
  Blockedby:             |    Blocking:                                   
-------------------------+--------------------------------------------------
Changes (by mtd):

  * keywords:  8.2.0:+ => 8.2.0:+ r?
  * next_action:  => never set


Comment:

 I think this is ready for testing now.

 I've pushed changes to #2, #3, and #4 to my d.l.o git repo.  It's easiest
 to review the attached patch, though[1].

 The main substance of it is the change to hardwaremanager.py.  The rest is
 just the knock-on effects.

 For review, I've included some test cases at the end.

 Martin

 1. I started off pushing lots of functionality into olpc-hardware-manager
 to fix a wider class of problems that #4, but #4 does not require this,
 and olpc-hardware-manager might not be the right place for this (though
 doing this would allow non-sugar apps to change the volume in a sugar-y
 way, but I think that's not the right way around to have the
 dependencies).

 2. Test cases: please note this bug affects sugar and sugar-toolkit; the
 patches needing review, however, only affect sugar (sugar-toolkit patch
 already reviewed and pushed to sugar-toolkit last week).

 |TestCase|

 7248.0: Show the speaker icon and click on the slider/adjustment widget to
 the left of its handle.  It should move an amount to the left and stop.
 Start an application playing that generates sound, so the volume changes
 in subsequent tests can be verified.


 |TestCase|

 7248.1: Show the speaker icon and click on the slider/adjustment widget to
 the left of its handle until the handle is more than halfway to the left.
 The icon should display as partially, but not entirely, full.


 |TestCase|

 7248.1: Show the speaker icon and click on the slider/adjustment widget to
 the left of its handle until it is most of the way to the left.  The icon
 should display as mostly, but not entirely, empty.


 |TestCase|

 7248.1: Show the speaker icon and move the slider/adjustment widget's
 handle all the way to the left.  The icon should become white and the
 "Mute" text & icon should change to "Unmute".


 |TestCase|

 7248.1: Show the speaker icon and move the slider/adjustment widget's
 handle all the way to the left.  The icon should become white and the
 "Mute" text & icon should change to "Unmute".  Now move the handle to the
 right one increment (by clicking or the right arrow key).  The icon should
 become un-white and the "Unmute" text & icon should change to "Mute".


 |TestCase|

 7248.2: Show the speaker icon and click "Mute".  The icon should become
 white and the "Mute" text & icon should change to "Unmute".


 |TestCase|

 7248.2: Show the speaker icon and click "Mute".  The icon should become
 white and the "Mute" text & icon should change to "Unmute".  Hide the
 speaker icon.  Show it again.  The icon should remain white and with the
 "Unmute" text/icon shown.  Repeat hiding and showing the icon three (3)
 times.


 |TestCase|

 7248.3: Show the speaker icon and move its slider's handle to somewhere
 near the middle.  Click "Mute".  The icon should become white and the
 "Mute" text & icon should change to "Unmute".  Now move the
 slider/adjustment widget's handle to the left or right and the icon should
 become un-white and the "Unmute" text & icon should change to "Mute".


 |TestCase|

 7248.4: Show the speaker icon and note its slider/adjustment's handle's
 position.  Press the XO volume up and volume down keys (F8, F9, IIRC) a
 few times to verify that those keys affect the slider.

-- 
Ticket URL: <http://dev.laptop.org/ticket/7248#comment:7>
One Laptop Per Child <http://laptop.org/>
OLPC bug tracking system