#7564 HIGH 8.2.0 (: Browse-filepicker: Remove file from list of files to delete after deleting it

Zarro Boogs per Child bugtracker at laptop.org
Sat Jul 19 03:28:48 EDT 2008


#7564: Browse-filepicker: Remove file from list of files to delete after deleting
it
-----------------------------+----------------------------------------------
 Reporter:  erikos           |         Owner:  erikos              
     Type:  defect           |        Status:  new                 
 Priority:  high             |     Milestone:  8.2.0 (was Update.2)
Component:  browse-activity  |       Version:  Git as of bug date  
 Keywords:  r?               |   Next_action:  review              
 Verified:  0                |     Blockedby:                      
 Blocking:                   |  
-----------------------------+----------------------------------------------
 In the current code the file is not removed from the list after deleting
 it.

 {{{
 diff --git a/filepicker.py b/filepicker.py
 index fe9fec5..a38de9a 100644
 --- a/filepicker.py
 +++ b/filepicker.py
 @@ -33,8 +33,12 @@ _browser_window = None

  def cleanup_temp_files():
      for temp_file in _temp_files_to_clean:
 -        logging.debug('filepicker.cleanup_temp_files: %r' % temp_file)
 -        os.remove(temp_file)
 +        if os.path.exists(temp_file):
 +            os.remove(temp_file)
 +            _temp_files_to_clean.remove(temp_file)
 +        else:
 +            logging.debug('filepicker.cleanup_temp_files: no file %r'
 +                          % temp_file)

  class FilePicker:
      _com_interfaces_ = interfaces.nsIFilePicker
 }}}

-- 
Ticket URL: <http://dev.laptop.org/ticket/7564>
One Laptop Per Child <http://laptop.org/>
OLPC bug tracking system


More information about the Bugs mailing list