#7485 HIGH Never A: no_console_suspend causes console output to be garbled

[Zarro Boogs per Child]

#7485: no_console_suspend causes console output to be garbled
-------------------------+--------------------------------------------------
   Reporter:  dsaxena    |       Owner:  dsaxena       
       Type:  defect     |      Status:  new           
   Priority:  high       |   Milestone:  Never Assigned
  Component:  kernel     |     Version:  Update.1      
 Resolution:             |    Keywords:                
Next_action:  never set  |    Verified:  0             
  Blockedby:             |    Blocking:                
-------------------------+--------------------------------------------------

Comment(by dsaxena):

 the following patch makes this problem go away though i'm surprised that
 nobody else has hit this since the commit that brings in the reset
 ns16550a on resume changes, b5b82df6f461e66af821bff5b51f336af92d96b6, is
 in olpc-2.6/stable.

 {{{
 diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c
 index d60705e..7d558d2 100644
 --- a/drivers/serial/8250.c
 +++ b/drivers/serial/8250.c
 @@ -2636,7 +2636,7 @@ void serial8250_resume_port(int line)
  {
         struct uart_8250_port *up = &serial8250_ports[line];

 -       if (up->capabilities & UART_NATSEMI) {
 +       if (up->capabilities & UART_NATSEMI && console_suspend_enabled) {
                 unsigned char tmp;

                 /* Ensure it's still in high speed mode */

 }}}

-- 
Ticket URL: <http://dev.laptop.org/ticket/7485#comment:1>
One Laptop Per Child <http://laptop.org/>
OLPC bug tracking system