#5485 HIGH Update.: Doesn't accept my Wep key anymore

[Zarro Boogs per Child]

#5485: Doesn't accept my Wep key anymore
-----------------------+----------------------------------------------------
  Reporter:  gdesmott  |       Owner:  mbletsas
      Type:  defect    |      Status:  reopened
  Priority:  high      |   Milestone:  Update.1
 Component:  wireless  |     Version:          
Resolution:            |    Keywords:          
  Verified:  0         |    Blocking:          
 Blockedby:            |  
-----------------------+----------------------------------------------------

Comment(by dcbw):

 Using libertas-2.6 head and applying the following makes it work for me:

 {{{
 diff --git a/drivers/net/wireless/libertas/main.c
 b/drivers/net/wireless/libertas/main.c
 index 91b2f23..0bd0c60 100644
 --- a/drivers/net/wireless/libertas/main.c
 +++ b/drivers/net/wireless/libertas/main.c
 @@ -938,6 +938,22 @@ static int lbs_setup_firmware(struct lbs_private
 *priv)
                 goto done;
         }

 +       /* Disable mesh autostart */
 +       if (1) {
 +               struct cmd_ds_mesh_access mesh_access;
 +               memset(&mesh_access, 0, sizeof(mesh_access));
 +               mesh_access.data[0] = cpu_to_le32(0);
 +               ret = lbs_mesh_access(priv,
 CMD_ACT_MESH_SET_AUTOSTART_ENABLED,
 +                                     &mesh_access);
 +               if (ret) {
 +                       printk("Mesh autostart set failed\n");
 +                       ret = 0;
 +                       //ret = -1;
 +                       goto done;
 +               }
 +               priv->mesh_autostart_enabled = 0;
 +       }
 +
         ret = 0;
  done:
         lbs_deb_leave_args(LBS_DEB_FW, "ret %d", ret);
 }}}

 The bisected commit 261d52b4874d5575f98b494ad4e669154f141a94 apparently
 moves mesh stuff around such that priv->mesh_dev is NULL at firmware setup
 time, which never turns off mesh autostart.  I believe we should be
 unconditionally be turning mesh autostart OFF, because autostart is only
 really useful in the active antenna case.  If the card is ever controlled
 by a driver them mesh autostart isn't useful since the driver/user knows
 when to start mesh better than the firmware itself.  We've had mesh
 autostart screw us hard with a sledgehammer before.

-- 
Ticket URL: <http://dev.laptop.org/ticket/5485#comment:62>
One Laptop Per Child <http://dev.laptop.org>
OLPC bug tracking system