#7911 NORM 9.1.0: Integration of speech-synthesis into sugar

[Zarro Boogs per Child]

#7911: Integration of speech-synthesis into sugar
---------------------------+------------------------------------------------
   Reporter:  hemantg      |       Owner:  erikos                                                
       Type:  enhancement  |      Status:  new                                                   
   Priority:  normal       |   Milestone:  9.1.0                                                 
  Component:  sugar        |     Version:  not specified                                         
 Resolution:               |    Keywords:  speech-dispatcher, speech synthesis, sugar-toolkit, r?
Next_action:  review       |    Verified:  0                                                     
  Blockedby:               |    Blocking:                                                        
---------------------------+------------------------------------------------

Comment(by erikos):

 main.py
  * The starting of the speech dispatcher should not be in
 _start_matchbox(). Please make a separate method for that (e.g.
 _start_speech_dispatcher). Later matchbox and speech-dispatcher start will
 be moved to SessionManager.

  * please don't hardcode /home/olpc use os.path.expanduser('~/.speechd/')
 instead that it works as well in jhbuild and on other systems

 speechmanager.py
  * I wonder if we should not move it into the shell - will ask marco about
 it

  * please don't hardcode /home/olpc use os.path.expanduser('~/.speechd/')
 instead that it works as well in jhbuild and on other systems

  * two times the copyright

  * set_speech_language() the emitted signal is not right self.emit
 ('speech-pitch-changed'...)

  * set_speech_voice() the emitted signal is not right

  * SSIPClient('sugar', 'main', 'olpc') the speech service is not olpc
 specific only

  * you should check that the conf file exist and that it is not corrupted.
 It is in a user writable place.

  * is there a reason the pydotconf API uses delete/add and not a set
 method?
 {{{
     self.conf_handle.delete_parameter(conf_volume)
     self.conf_handle.add_parameter([new_volume])
 }}}

  * the global variable could maybe be _sppechmanager instead of _speech


 model/devices//speech.py

  * _get_language must be _get_speech_language

 view/devices/speech.py

  * _update_info: self.icon.props.icon_name = "speech" - use the _ICON_NAME
 here

  * SpeechPalette: please remove the uncommented lines and move the
 self._pitchscale.show() after the adding to the table

 general notes:

  * Please modify the Makefiles.am in view/devices and model/devices and
 sugar-toolkit/src/sugar

  * run 'make distcheck' to check which files must be added to
 po/POTFILES.in for translation

  * clean pylint picks in sugar/src/view/devices/speech.py and
 src/sugar/speechmanager.py

  * the speech device icon has no stroke color defined - maybe best to open
 a ticket for eben to review the icon

-- 
Ticket URL: <http://dev.laptop.org/ticket/7911#comment:3>
One Laptop Per Child <http://laptop.org/>
OLPC bug tracking system