#948 HIGH Trial-3: NM: key only allows hex entry

[Zarro Boogs per Child]

#948: NM: key only allows hex entry
---------------------+------------------------------------------------------
  Reporter:  bert    |       Owner:  tomeu  
      Type:  defect  |      Status:  new    
  Priority:  high    |   Milestone:  Trial-3
 Component:  sugar   |     Version:         
Resolution:          |    Keywords:  review?
  Verified:  0       |  
---------------------+------------------------------------------------------
Changes (by tomeu):

 * cc: dcbw, jg (added)
  * keywords:  => review?


Comment:

 The attached patch accepts a hex key if it starts with '$:', an ascii
 passphrase of 5 or 13 chars if it starts with 's:' and any other string as
 a passphrase that will be hashed with md5 in order to get a key of 26
 bytes.

 The drawback of this approach is that we cannot do any kind of validation
 as any string can be interpreted as a valid key. If we required for md5
 passphrases to be prefixed with for example 'm:', then we could do some
 better validation of the input.

 This is only for WEP. Passphrases for WPA still have to be implemented,
 although I'm not sure if for Trial-3.

 Dan, can you give it a look and give your opinion?

-- 
Ticket URL: <https://dev.laptop.org/ticket/948#comment:6>
One Laptop Per Child <https://dev.laptop.org>
OLPC bug tracking system