#4454 HIGH Never A: Activity will not close if the write_file method raises an exception (was: Read will not close if the PDF file fails to load)
Zarro Boogs per Child
bugtracker at laptop.org
Wed Oct 31 04:23:22 EDT 2007
#4454: Activity will not close if the write_file method raises an exception
---------------------+------------------------------------------------------
Reporter: pascal | Owner: tomeu
Type: defect | Status: reopened
Priority: high | Milestone: Never Assigned
Component: sugar | Version:
Resolution: | Keywords:
Verified: 0 |
---------------------+------------------------------------------------------
Changes (by tomeu):
* status: closed => reopened
* cc: marco, Eben (added)
* component: read-activity => sugar
* keywords: review? =>
* resolution: fixed =>
Comment:
Hmm, perhaps that should be done in the base activity class? The catch
being too broad doesn't look like a problem to me, we should expect that
errors will happen occasionally on the methods implemented by the activity
authors, and the laptop should continue to work as expected by the user.
On the other side, silently ignoring an error in the write_file could make
the user think that his work gets saved when it's not being saved. A
message in the logs doesn't look like a good way to alert about this.
Perhaps we should show a non-modal alert when that happens allowing the
user to close an activity that fails to save its state?
For now, I think the fix in Read make sense.
--
Ticket URL: <https://dev.laptop.org/ticket/4454#comment:2>
One Laptop Per Child <https://dev.laptop.org>
OLPC bug tracking system
More information about the Bugs
mailing list