#4372 NORM First D: Salut tubes announcement protocol doesn't deal with groups merging

[Zarro Boogs per Child]

#4372: Salut tubes announcement protocol doesn't deal with groups merging
-----------------------------+----------------------------------------------
 Reporter:  smcv             |       Owner:  gdesmott              
     Type:  defect           |      Status:  new                   
 Priority:  normal           |   Milestone:  First Deployment, V1.0
Component:  telepathy-salut  |     Version:  Git as of bug date    
 Keywords:                   |    Verified:  0                     
-----------------------------+----------------------------------------------
 I think this might be causing #4127.

 {{{
 10:06 < sjoerd> smcv: fwiw, my testing revealed that the current tubes
                 initiation protocol stuff on salut is somewhat broken, so
 it'd
                 be good to fix that asap :)
 10:06 < smcv> sjoerd: it is?
 10:07 < smcv> that may be a known bug or not, I'm losing track
 10:07 < sjoerd> It seems salut only requests a listing of the tubes once
 10:07 < smcv> and that's a problem because?
 10:07 < sjoerd> After the muc channel signal connected.. Which is broken
 if two
                 connected groups join eachother
 10:08 < cassidy> I think you planned to change that, right?
 10:08 < smcv> in my draft protocol spec, we send the <tubes/> message
               automatically whenever a join event occurs
 10:08 < sjoerd> Before i fixed salut to only signal connected after seeing
                 other members it would go like: connected -> request tubes
 ->
                 members changes (other members come in) -> loss :)
 10:09 < smcv> as you say, epic loss
 10:09 < smcv> I don't think there should ever be an explicit request
 10:09 < sjoerd> probably not
 10:09 < smcv> it should just be: join event => send our tubes messages
 10:09 < sjoerd> People should announce their tubes as soon as they see
 people
                 have joined
 10:09 < smcv> and avoid wasting bandwidth on "hello, do you have any
 tubes?"
 10:10 < sjoerd> nod
 10:10 < smcv> sjoerd: is it easy for the tubes channel to spot join
 events?
 10:10 < smcv> by hooking a signal on one of the transport layers/
 10:10 < smcv> s,/,?,
 10:10 < sjoerd> yeah
 10:11 < sjoerd> It's basically just hooking into the same signalling the
 muc
                 channel uses to change the group members
 10:12 < smcv> great
 10:12 < sjoerd> so you either listen to new-senders on gibber-muc-
 connection or
                 to group changes on the salut muc channel.. and your fine
 10:12 < sjoerd> new-senders gives you the full array of new senders of the
                 join.. So your also guaranteed to only get that signal
 once for
                 each join :)
 10:12 < sjoerd> == winning :p
 10:13 < smcv> cassidy: can you code that up please? send out the <tubes/>
 in
               response to GibberMucConection::new-senders, and never send
               explicit requests
 }}}

-- 
Ticket URL: <https://dev.laptop.org/ticket/4372>
One Laptop Per Child <https://dev.laptop.org>
OLPC bug tracking system