#2028 NORM Trial-3: Activities in ring need rollovers

[Zarro Boogs per Child]

#2028: Activities in ring need rollovers
---------------------+------------------------------------------------------
  Reporter:  Eben    |       Owner:  marco  
      Type:  defect  |      Status:  new    
  Priority:  normal  |   Milestone:  Trial-3
 Component:  sugar   |     Version:         
Resolution:          |    Keywords:  review+
  Verified:  0       |  
---------------------+------------------------------------------------------
Changes (by marco):

  * keywords:  review? => review+

Comment:

 +import gtk
  +from gettext import gettext as _

   from sugar.graphics.canvasicon import CanvasIcon
  +from sugar.graphics.palette import Palette

 Nitpick... Per the style guide imports should be grouped as 1 standard
 python library 2 third party (gtk etc) 3 local. So gettext should go in
 the first group.

  +        # FIXME: kludge
  +        if self._activity.get_type() != "org.laptop.JournalActivity":

 Activity has a can_close property but I'm not sure it's worth exposing it
 in the DBus service. So the kludge should be fine at least for now.

  +    def _update_palette(self):

 I think it should be _setup_palette since it cannot be called multiple
 times.

  +        if activity_host:
  +            activity_host.present()

 Let's not fail silently on this. A logging.error will do.

 Please push once the above are fixed. Thanks!

-- 
Ticket URL: <http://dev.laptop.org/ticket/2028#comment:3>
One Laptop Per Child <http://laptop.org/>