[Testing] buildbot for sugar-jhbuild

[Titus Brown]

On Mon, Mar 31, 2008 at 11:42:00AM +0200, Marco Pesenti Gritti wrote:
-> Titus Brown wrote:
-> >I've placed a temporary buildbot here,
-> >
-> >	http://iorich.caltech.edu:8014/
-> 
-> Cool! It would be good to also have a Fedora 8 buildslave too.

OK, I'll put that on my TODO list :)

-> >I would really like to test building things from scratch once daily, but
-> >I'm not sure how the owners of the machines hosting all of the packages
-> >would feel about that.  Any thoughts?
-> >  
-> 
-> It sounds good. I don't really think that would be a problem.

Ditto, TODO.  I'm sure I'll find out if there are any complaints rather
quickly...!

-> >Also, would it possible to have sugar-jhbuild exit with a non-zero error
-> >whenever anything goes wrong, like a missing dependency?  Compilation
-> >was finishing suspiciously fast because (as it turned out) simplejson
-> >suddenly became a new requirement :)
-> 
-> Fixed.

I was still having some problems with sugar-jhbuild failing to fail on
unbuilt packages; I tracked down the problem (command return codes
weren't getting passed up the call stack) and fixed it.  Here's a patch
(attached, also):

	http://iorich.caltech.edu/~t/transfer/die-properly.patch.txt

Please let me know if it's OK.

thanks,
--titus

p.s. I'd publish it on a git branch, but I'm doing all of this on VMs
and I don't have a git repos set up on my dev machines yet.  Sorry.
Soon!
-------------- next part --------------
diff --git a/build-scripts/jhbuild/jhbuild/commands/base.py b/build-scripts/jhbuild/jhbuild/commands/base.py
diff --git a/build-scripts/jhbuild/jhbuild/frontends/__init__.py b/build-scripts/jhbuild/jhbuild/frontends/__init__.py
diff --git a/build-scripts/jhbuild/jhbuild/main.py b/build-scripts/jhbuild/jhbuild/main.py
diff --git a/main.py b/main.py
index e8dc959..403b5fa 100644
--- a/main.py
+++ b/main.py
@@ -96,7 +96,7 @@ def main(args):
         args.append('sugar-emulator')
 
     try:
-        jhbuild.commands.run(command, config, args)
+        return jhbuild.commands.run(command, config, args)
     except UsageError, exc:
         sys.stderr.write('sugar-jhbuild %s: %s\n' % (command, str(exc)))
         parser.print_usage()
diff --git a/sugar-jhbuild b/sugar-jhbuild
index 5cd450c..0f1154c 100755
--- a/sugar-jhbuild
+++ b/sugar-jhbuild
@@ -16,4 +16,4 @@ if len(sys.argv) == 1 or (len(sys.argv) > 1 and sys.argv[1] == 'build'):
 
 import main
 
-main.main(sys.argv[1:])
+sys.exit(main.main(sys.argv[1:]))