<br><br><div class="gmail_quote">On Sun, Jun 8, 2008 at 1:42 PM, Marco Pesenti Gritti <<a href="mailto:mpgritti@gmail.com">mpgritti@gmail.com</a>> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
On Sun, Jun 8, 2008 at 9:26 PM, Jameson Chema Quinn<br>
<div class="Ih2E3d"><<a href="mailto:jquinn@cs.oberlin.edu">jquinn@cs.oberlin.edu</a>> wrote:<br>
</div><div class="Ih2E3d">> Here is the revised patch. It has your suggested changes, plus a couple<br>
> more:<br>
><br>
> - Check for existence of po directory in Builder<br>
> - Config.__init__() is cleaned up. Now gets bundle name from <a href="http://activity.info" target="_blank">activity.info</a>.<br>
> start() no longer needs a bundle name, and has deprecation warning. Also I<br>
> put things in a more logical order.<br>
<br>
</div>Jameson,<br>
<br>
*please* do *not* make any additional changes when submitting a new<br>
patch. Limit yourself to the changes requested by the reviewer.<br>
Additional fixes/improvements should go in a separate patch.<br>
</blockquote><div><br>OK.<br><br>In my defense, you did ask me to remove the extra parameters from the __init__ functions. The best way to do that was to clean up Config. <br><br>The po check, you are right, should be separate, even though it is only a simple 3-line patch.<br>
</div></div><br>Sorry,<br>Jameson<br>