<br><br><div class="gmail_quote">On Wed, May 28, 2008 at 12:16 PM, Tomeu Vizoso <<a href="mailto:tomeu@tomeuvizoso.net">tomeu@tomeuvizoso.net</a>> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Hi,<br>
<br>
+ if self._jobject.is_activity_bundle():<br>
+ menu_item = MenuItem(_('Start'))<br>
+ menu_item.connect('activate', self._resume_menu_item_activate_cb,<br>
+ None)<br>
+ palette.menu.append(menu_item)<br>
+ menu_item.show()<br>
<br>
Why are we adding a Start menu item? How is it different from clicking<br>
on the button?<br>
</blockquote><div><br>We add a start menu item in case there is a choice to run or open with; if there are choices, they should all be listed, even if one is available in a simpler way (by just clicking). Also note that I plan, in the future, to make the default behavior (clicking on the button) configurable using metadata, so that you can have some bundles which are "for editing".<br>
<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
- self._jobject.resume(service_name)<br>
+ if not service_name:<br>
+ self._jobject.resume()<br>
+ else:<br>
+ self._jobject.resume(service_name)<br>
<br>
Why is this needed? self._jobject.resume(service_name) when<br>
service_name == None should be the same as self._jobject.resume().</blockquote><div><br>Fixed. <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
<br>
The rest seems good to me.<br>
<br>
Thanks,<br>
<br>
Tomeu<br>
_______________________________________________<br>
Sugar mailing list<br>
<a href="mailto:Sugar@lists.laptop.org">Sugar@lists.laptop.org</a><br>
<a href="http://lists.laptop.org/listinfo/sugar" target="_blank">http://lists.laptop.org/listinfo/sugar</a><br>
</blockquote></div><br>