[sugar] [PATCH] REVISED screenshots hurt

[Eben Eliason]

On Thu, Sep 11, 2008 at 12:39 PM, Erik Garrison <erik at laptop.org> wrote:
> I have revised and tested the patches.  The effects are as follows:
>
> On Fri, Sep 05, 2008 at 01:31:54AM -0300, Erik Garrison wrote:
>>   before, screenshots taken on these events:
>>     - frame visibility
>>     - tabbing start
>>     - activity next tab
>>     - activity previous tab
>>     - zoom into activity view
>>     - activity close (twice)
>>
>>   after, screenshots taken on these events:
>>     - activity close (once)
>>     - activity keep / save
>
> I dropped the screenshot acquisition code into Activity.copy() and
> Activity.close() so that both user-initated 'keep' (==copy) and 'close'
> events (both keyboard initiated and frame-click initiated) will take
> screenshots for use in the journal.
>
> The patches are attached to this email.  Should I make a new track
> ticket for this issue to log the introduction?
>
> Any objections or thoughts?

I still think this is going to be doing the wrong thing about half the
time, as long as there is no check to be sure that the activity is
visible at the time the screenshot is taken. (There also seems to be
no avoiding the fact that the Frame will be in many of them...) I'd
rather have no preview than an incorrect one.

- Eben


> Erik
>
> _______________________________________________
> Sugar mailing list
> Sugar at lists.laptop.org
> http://lists.laptop.org/listinfo/sugar
>
>