[sugar] [PATCH] REVISED screenshots hurt

Erik Garrison erik at laptop.org
Thu Sep 11 12:39:22 EDT 2008


I have revised and tested the patches.  The effects are as follows:

On Fri, Sep 05, 2008 at 01:31:54AM -0300, Erik Garrison wrote:
>   before, screenshots taken on these events:
>     - frame visibility
>     - tabbing start
>     - activity next tab
>     - activity previous tab
>     - zoom into activity view
>     - activity close (twice)
> 
>   after, screenshots taken on these events:
>     - activity close (once)
>     - activity keep / save

I dropped the screenshot acquisition code into Activity.copy() and
Activity.close() so that both user-initated 'keep' (==copy) and 'close'
events (both keyboard initiated and frame-click initiated) will take
screenshots for use in the journal.

The patches are attached to this email.  Should I make a new track
ticket for this issue to log the introduction?

Any objections or thoughts?

Erik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sugar-no_screen_shots.patch
Type: text/x-diff
Size: 2205 bytes
Desc: not available
Url : http://lists.laptop.org/pipermail/sugar/attachments/20080911/024344bf/attachment.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sugar-toolkit-no_screen_shots.patch
Type: text/x-diff
Size: 1040 bytes
Desc: not available
Url : http://lists.laptop.org/pipermail/sugar/attachments/20080911/024344bf/attachment-0001.patch 


More information about the Sugar mailing list