[sugar] [PATCH] Merge the journal activity into the shell

[Marco Pesenti Gritti]

On Tue, Sep 9, 2008 at 1:48 PM, Tomeu Vizoso <tomeu at tomeuvizoso.net> wrote:
> Hi,
>
> this patch moves the journal into the shell, so we save some (quite a
> bit) of memory and make easier some interactions between the journal
> and the shell.
>
> http://dev.laptop.org/~tomeu/0001-Merge-the-journal-into-the-shell.patch

I can't review the part of the code that you moved obviously. If you
made important changes there I will need a diff.

* You left debug code in setup_palette.
* FocusSearch is called through dbus, shouldn't we make it a normal call?
* I wonder if it would be easier to add a "builtin" journal activity
to the registry, instead of special casing the model.

-        # Checking for the bundle existence will also ensure
-        # that the shell service is started up.
-        registry = activity.get_registry()
-        if registry.get_activity('org.laptop.JournalActivity'):
-            self.start_activity('org.laptop.JournalActivity')

I assume you checked that this is not necessary anymore.

Marco