[sugar] Error building squeak in jhbuild on Ubuntu 8.10

[Morgan Collett]

On Thu, Nov 6, 2008 at 13:01, Morgan Collett <morgan.collett at gmail.com> wrote:
> When building jhbuild on Ubuntu 8.10, I get the following error building squeak:
>
> /bin/bash /home/morgan/sugar-jhbuild/source/squeak/bld/libtool
> --mode=compile gcc -g -O2 -fomit-frame-pointer -DLSB_FIRST=1 -g -O2
> -fomit-frame-pointer -DLSB_FIRST=1 -Wall -Werror -DHAVE_CONFIG_H
> -I/home/morgan/sugar-jhbuild/source/squeak/bld
> -I/home/morgan/sugar-jhbuild/source/squeak/platforms/unix/vm
> -I/home/morgan/sugar-jhbuild/source/squeak/platforms/Cross/vm
> -I/home/morgan/sugar-jhbuild/source/squeak/platforms/unix/src/vm
> -I/home/morgan/sugar-jhbuild/source/squeak/bld
> -I/home/morgan/sugar-jhbuild/source/squeak/platforms/unix/vm
> -I/home/morgan/sugar-jhbuild/source/squeak/platforms/Cross/vm
> -I/home/morgan/sugar-jhbuild/source/squeak/platforms/unix/src/vm
> -I/home/morgan/sugar-jhbuild/source/squeak/platforms/Cross/plugins/FilePlugin
> -I/home/morgan/sugar-jhbuild/source/squeak/platforms/Cross/plugins/B3DAcceleratorPlugin
> -I/home/morgan/sugar-jhbuild/source/squeak/platforms/unix/plugins/B3DAcceleratorPlugin
> -DSUGAR  -c -o sqUnixFBDev.lo
> /home/morgan/sugar-jhbuild/source/squeak/platforms/unix/vm-display-fbdev/sqUnixFBDev.c
> gcc -g -O2 -fomit-frame-pointer -DLSB_FIRST=1 -g -O2
> -fomit-frame-pointer -DLSB_FIRST=1 -Wall -Werror -DHAVE_CONFIG_H
> -I/home/morgan/sugar-jhbuild/source/squeak/bld
> -I/home/morgan/sugar-jhbuild/source/squeak/platforms/unix/vm
> -I/home/morgan/sugar-jhbuild/source/squeak/platforms/Cross/vm
> -I/home/morgan/sugar-jhbuild/source/squeak/platforms/unix/src/vm
> -I/home/morgan/sugar-jhbuild/source/squeak/bld
> -I/home/morgan/sugar-jhbuild/source/squeak/platforms/unix/vm
> -I/home/morgan/sugar-jhbuild/source/squeak/platforms/Cross/vm
> -I/home/morgan/sugar-jhbuild/source/squeak/platforms/unix/src/vm
> -I/home/morgan/sugar-jhbuild/source/squeak/platforms/Cross/plugins/FilePlugin
> -I/home/morgan/sugar-jhbuild/source/squeak/platforms/Cross/plugins/B3DAcceleratorPlugin
> -I/home/morgan/sugar-jhbuild/source/squeak/platforms/unix/plugins/B3DAcceleratorPlugin
> -DSUGAR -c /home/morgan/sugar-jhbuild/source/squeak/platforms/unix/vm-display-fbdev/sqUnixFBDev.c
>  -fPIC -DPIC -DPIC -o sqUnixFBDev.o
> cc1: warnings being treated as errors
> In file included from
> /home/morgan/sugar-jhbuild/source/squeak/platforms/unix/vm-display-fbdev/sqUnixFBDevMouse.c:109,
>                 from
> /home/morgan/sugar-jhbuild/source/squeak/platforms/unix/vm-display-fbdev/sqUnixFBDev.c:128:
> /home/morgan/sugar-jhbuild/source/squeak/platforms/unix/vm-display-fbdev/sqUnixFBDevMousePS2.c:
> In function 'ms_ps2_send':
> /home/morgan/sugar-jhbuild/source/squeak/platforms/unix/vm-display-fbdev/sqUnixFBDevMousePS2.c:113:
> error: ignoring return value of 'write', declared with attribute
> warn_unused_result
> /home/morgan/sugar-jhbuild/source/squeak/platforms/unix/vm-display-fbdev/sqUnixFBDevMousePS2.c:
> In function 'ms_ps2_disable':
> /home/morgan/sugar-jhbuild/source/squeak/platforms/unix/vm-display-fbdev/sqUnixFBDevMousePS2.c:144:
> error: ignoring return value of 'write', declared with attribute
> warn_unused_result
> make[2]: *** [sqUnixFBDev.lo] Error 1
> make[1]: *** [vm-display-fbdev.la] Error 2
> make[1]: Leaving directory `/home/morgan/sugar-jhbuild/source/squeak/bld'
> make: *** [default] Error 2
> *** error during stage build of squeak: ########## Error running make
>  *** [22/36]
>
> This has also been reported by the developer packaging squeak for Ubuntu:
> https://bugs.launchpad.net/ubuntu/+source/squeak-vm/+bug/254547
>
> That bug report suggests building with -D_FORTIFY_SOURCE=0 - or is
> there a better way of fixing this?

For the record, I did get squeak to build in jhbuild by manually
configuring it with -D_FORTIFY_SOURCE=0. Is this an appropriate fix
suitable for upstream, or can somebody suggest a better approach?

Thanks
Morgan