[sugar] gadget 'test' branch

Dafydd Harries dafydd.harries at collabora.co.uk
Thu May 22 10:36:53 EDT 2008


Ar 20/05/2008 am 10:47, ysgrifennodd Guillaume Desmottes:
> Le mardi 20 mai 2008 à 01:47 +0100, Dafydd Harries a écrit :
> > Could you review my 'test' branch of Gadget? I put it in my ~ on
> > dev.laptop.org; hopefully it will show up in gitweb soon.
> 
> 
> +        if properties:
> Shouldn't it be "if properties is None" ?

I think in this case it doesn't make a difference, because if 'properties' is
False, it will be the empty dictionary, which will have the same effect.

> I guess we can remove sort_activity() now?

I think I will try to make a similar change for buddy queries, and then remove
both sort_activity and sort_buddy.
> Thanks for moving your dev branch to your public_git repo (git remote
> FTW :)

Yeah, I think it makes sense now that we have more than one person working on
it. :)

-- 
Dafydd


More information about the Sugar mailing list