[sugar] review: gadget buddy search code

[Dafydd Harries]

Ar 15/05/2008 am 20:33, ysgrifennodd Dafydd Harries:
> Otherwise, go ahead and merge.

A couple of other nitpicks:

> +class ParsePropertiesTest(TrialTestCase):
...
> +class PropertiesToXmlTest(TrialTestCase):

These don't use any Trial features, so could just be unittest.TestCases.

> +        try:
> +            parse_properties(properties)
> +        except PropertyTypeError, e:
> +            pass
> +        else:
> +            assert False, "should not be reached"

self.assertRaises is the idiomatic way to do this.

-- 
Dafydd