[sugar] web-activity fix

Dan Krejsa dan.krejsa at alamedanet.net
Sun May 11 13:56:53 EDT 2008


Hi,

The attached change in web-activity/downloadmanager.py fix a
problem causing Browse downloads to fail with an exception in
onProgressChange64() due to _create_journal_object() having failed
to be called earlier from onStateChange() when state_flags contained
the bit STATE_START, but also other bits as corresponding to
State Type Flags from nsIWebProgressListener.idl.

I'm pretty confident about the changes in onStateChange(), but
the change (eliminating a trailing '"' character) in the
components.registrar.registerFactory() calls are fairly gratuitous,
and should be checked by someone who is familiar with that API.

- Dan


-------------- next part --------------
A non-text attachment was scrubbed...
Name: downloadmanager.py.diff
Type: text/x-patch
Size: 1866 bytes
Desc: not available
Url : http://lists.laptop.org/pipermail/sugar/attachments/20080511/57331907/attachment.bin 


More information about the Sugar mailing list