[sugar] [review] controlpanel - modularize model

Simon Schampijer simon at schampijer.de
Sat May 10 15:38:25 EDT 2008


Hello,

http://dev.laptop.org/~erikos/001_controlpanel.patch
is the full patch.

And you can see the splited patches (the last two) here: 
http://dev.laptop.org/git?p=users/erikos/sugar;a=shortlog;h=master

Question:
One thing I can not figure out, is how the list of POTFILES in 
po/Makefile get generated. It is still looking for this file 
shell/controlpanel/control.py even so it is not present anymore, any idea?

Thanks,
    Simon


Marco Pesenti Gritti wrote:
> Hello,
> 
> even if it's going to be big, I think it makes more sense to review
> this as a single patch. I need to get a good sense of the overall
> design...
> 
> Marco
> 
> On Fri, May 9, 2008 at 6:41 PM, Simon Schampijer <simon at schampijer.de> wrote:
>> Hi,
>>
>> the first patch to review will modularize the model. Each section has a file
>> with it's set/get/print functions placed in a folder called model.
>>
>> This will then be used by the command-line-interface and the graphical
>> frontend.
>>
>> The timezone is using the environment variable 'TZ' which is set in the main
>> function of the shell. The second patch adds the variable to the sugar
>> config. All this was done to avoid to use root (since the timezone method
>> had to write to /etc/sysconfig/clock before).
>>
>> Best,
>>   Simon
>>
>> _______________________________________________
>> Sugar mailing list
>> Sugar at lists.laptop.org
>> http://lists.laptop.org/listinfo/sugar
>>
>>
> 



More information about the Sugar mailing list