[sugar] Merging sugar-toolkit changes from tomeu repository
Tomeu Vizoso
tomeu at tomeuvizoso.net
Fri Mar 28 15:37:07 EDT 2008
On Fri, Mar 28, 2008 at 8:13 PM, Tomeu Vizoso <tomeu at tomeuvizoso.net> wrote:
> On Fri, Mar 28, 2008 at 6:46 PM, Marco Pesenti Gritti
> <mpgritti at gmail.com> wrote:
> > On Fri, Mar 28, 2008 at 6:19 PM, Tomeu Vizoso <tomeu at tomeuvizoso.net> wrote:
> > + def set_tooltip(self, tooltip):
> > + if self._tooltip != tooltip:
> > + self._tooltip = tooltip
> > + if tooltip and self.palette is None:
> > + self.palette = Palette(tooltip)
> > + elif self.palette:
> > + self.palette.set_primary_text(tooltip)
> >
> > Is the if at the top really necessary? I can't think of use cases
> > where we would be hitting it.
> > Also I'd replace the palette if you set_tooltip and a Palette already exist.
>
> How so?
Ok, this is the only standing issue in the attached patch.
Thanks,
Tomeu
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-support-for-accelerators-to-buttons.patch
Type: text/x-patch
Size: 13618 bytes
Desc: not available
Url : http://lists.laptop.org/pipermail/sugar/attachments/20080328/6e84979a/attachment-0001.bin
More information about the Sugar
mailing list