[sugar] [PATCH] Persist position of favorite icons

Simon Schampijer simon at schampijer.de
Thu Jun 12 07:07:49 EDT 2008


Tomeu Vizoso wrote:
> Hi,
> 
> these two patches are the continuation of the work to implement a new
> favorites screen in the home view.
> 
> Thanks,
> 
> Tomeu

Hi,

looks good.

+++ service/bundleregistry.py
Nitpicks:
W: 56:BundleRegistry.__init__: Unused variable 'e'
C:108: Line too long (81/80)

+++ b/src/view/home/activitiesring.py 
 
 

+        hot_spot = style.zoom(10)
Maybe a constant for the 10?

+++ b/src/view/home/activitiesring.py
+ self._fixed_positions[icon] = (relative_x * 1000 / width
Should we use a constant for the 1000?

Thanks,
    Simon


More information about the Sugar mailing list