[sugar] [PATCH] Adapt object chooser to new designs. Some refactoring was needed.

Simon Schampijer simon at schampijer.de
Tue Jun 10 13:13:30 EDT 2008


Tomeu Vizoso wrote:
> Hi,
> 
> this patch adapts the object chooser to the mockups linked below. It
> was needed to refactor the ListView and CollapsedEntry classes in
> order to separate the common functionality between the journal list
> view and the one in the object chooser.
> 
> Thanks,
> 
> Tomeu
> 

Hi Tomeu,

looks very nice your code - even fixes a lot of pylint warnings :)

One note:

*** objectchooser.py:
I think we don't have to pass the parent window to ObjectChooser(gtk.Window). This 
is how we handle it as well for the controlpanel (was a suggestion by marco as well).

chooser = ObjectChooser()
chooser.set_transient_for(parent)
chooser.show()

Could not see the code in action yet since I am updating on F-9 currently :/ but 
the logic looks very good.

Best,
    Simon


More information about the Sugar mailing list